Re: [Qemu-devel] [PULL 0/8] tcg-ia64 ldst updates

[Aurelien Jarno]

On Tue, Mar 04, 2014 at 11:00:59AM -0800, Richard Henderson wrote:
> This is a revival of a patch set I submitted back in September.

Well the patch set from September was much different and was followed by
a new version in October to which I answered, and even acked a few
patches.

> I've just re-tested it and things still look ok, so I'm just going
> to ask for a pull rather than pretending there might be review.

Anyway this new version still doesn't work for 64-bit big endian guest,
so this is a NACK. This can be easily tested with for example a MIPS64
guest using these images: http://people.debian.org/~aurel32/qemu/mips/

Aurelien

> 
> r~
> 
> 
> The following changes since commit 4a29420ea1c5a34191281855f5f51e70deab8940:
> 
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' 
> into staging (2014-03-04 16:33:25 +0000)
> 
> are available in the git repository at:
> 
>   git://github.com/rth7680/qemu.git tcg-ldst-ia64
> 
> for you to fetch changes up to 97d3dfedfd137ef7e2ae77fc9d518594be1a8f43:
> 
>   tcg-ia64: Convert to new ldst opcodes (2014-03-04 09:35:56 -0800)
> 
> ----------------------------------------------------------------
> Richard Henderson (8):
>       tcg-ia64: Optimize small arguments to exit_tb
>       tcg-ia64: Re-bundle the tlb load
>       tcg-ia64: Move bswap for store into tlb load
>       tcg-ia64: Move tlb addend load into tlb read
>       tcg-ia64: Reduce code duplication in tcg_out_qemu_ld
>       tcg-ia64: Convert to new ldst helpers
>       tcg-ia64: Move part of softmmu slow path out of line
>       tcg-ia64: Convert to new ldst opcodes
> 
>  tcg/ia64/tcg-target.c | 497 
> ++++++++++++++++++++++++++------------------------
>  tcg/ia64/tcg-target.h |   2 +-
>  2 files changed, 264 insertions(+), 235 deletions(-)
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net