Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser

[Andreas Färber]

Am 08.03.2014 19:47, schrieb Leandro Dorileo:
> The following patchset introduces a general purpose argument parser and 
> migrates
> qemu-img to make use of it. qemu-img is just the first user of it, if we see a
> good feedback here I move forward and migrate all the other possible users.

Why? :) You forgot to describe what's wrong with the current
infrastructure, how your approach is different and what the benefit is.

Regards,
Andreas

> Leandro Dorileo (2):
>   qemu-arg: introduce a general purpose argument parser
>   qemu-img: migrate to use qemu-arg
> 
>  .gitignore              |    1 +
>  Makefile                |   12 +-
>  include/qemu/qemu-arg.h |  287 ++++++++++++
>  qemu-img-cmds.hx        |   77 ---
>  qemu-img-descs.h        |  128 +++++
>  qemu-img.c              | 1184 
> ++++++++++++++++-------------------------------
>  util/Makefile.objs      |    1 +
>  util/qemu-arg.c         |  887 +++++++++++++++++++++++++++++++++++
>  8 files changed, 1706 insertions(+), 871 deletions(-)
>  create mode 100644 include/qemu/qemu-arg.h
>  delete mode 100644 qemu-img-cmds.hx
>  create mode 100644 qemu-img-descs.h
>  create mode 100644 util/qemu-arg.c
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg