[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode |
Date: |
Sun, 9 Mar 2014 21:20:35 +0200 |
From: Hervé Poussineau <address@hidden>
In write-only mode, writes are forwarded to RAM, while reads should not be
handled (ie should return 0xff).
Assume that in this mode, no read access is ever done, as they shouldn't
give any sensible result.
So, in write-only mode, alias PAM region to RAM, instead of PCI memory
(which can even be mapped to some device!)
This fixes Award BIOS, which use this mode to shadow system BIOS and video BIOS.
Signed-off-by: Hervé Poussineau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci-host/pam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c
index ec6be46..e1e95aa 100644
--- a/hw/pci-host/pam.c
+++ b/hw/pci-host/pam.c
@@ -68,7 +68,7 @@ void init_pam(DeviceState *dev, MemoryRegion *ram_memory,
/* XXX: should distinguish read/write cases */
memory_region_init_alias(&mem->alias[0], OBJECT(dev), "pam-pci",
pci_address_space,
start, size);
- memory_region_init_alias(&mem->alias[2], OBJECT(dev), "pam-pci",
pci_address_space,
+ memory_region_init_alias(&mem->alias[2], OBJECT(dev), "pam-pci",
ram_memory,
start, size);
for (i = 0; i < 4; ++i) {
--
MST
- [Qemu-devel] [PULL v3 01/14] acpi-build: append description for non-hotplug, (continued)
- [Qemu-devel] [PULL v3 01/14] acpi-build: append description for non-hotplug, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 02/14] acpi-test-data: update expected files, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 03/14] virtio-net: remove function calls from assert, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 04/14] memory_region_present: return false if address is not found in child MemoryRegion, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 06/14] Rework --name to use QemuOpts, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 05/14] PCIE: fix regression with coldplugged multifunction device, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to qemu_thread_create, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 09/14] MAINTAINERS: drop an out of date address, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 10/14] acpi-test: retain both asl and aml files on failure, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 11/14] acpi-test: issue errors instead of warnings when possible, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 13/14] pckbd: return 'keyboard enabled' on read input port command, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 14/14] qemu: x86: ignore ioapic polarity, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name, Michael S. Tsirkin, 2014/03/09
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/10
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/10
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11