qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA
Date: Sun, 09 Mar 2014 21:57:06 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 09/03/14 11:02, Sebastian Huber wrote:

The LEON3 processor has support for the CASA instruction which is
normally only available for SPARC V9 processors. Binutils 2.24
and GCC 4.9 will support this instruction for LEON3. GCC uses it to
generate C11 atomic operations.

The CAS synthetic instruction uses an ASI of 0x80. If TARGET_SPARC64 is
not defined use a supervisor data load/store for an ASI of 0x80 in
helper_ld_asi()/helper_st_asi(). The supervisor data load/store was
choosen according to the LEON3 documentation.

The ASI 0x80 is defined in the SPARC V9 manual, Table 12—Address Space
Identifiers (ASIs). Here we have: 0x80, ASI_PRIMARY, Unrestricted
access, Primary address space.

Tested with the following program:

#include <assert.h>
#include <stdatomic.h>

void test(void)
{
atomic_int a;
int e;
_Bool b;

atomic_store(&a, 1);
e = 1;
b = atomic_compare_exchange_strong(&a, &e, 2);
assert(b);
assert(atomic_load(&a) == 2);

atomic_store(&a, 3);
e = 4;
b = atomic_compare_exchange_strong(&a, &e, 5);
assert(!b);
assert(atomic_load(&a) == 3);
}

Tested also on a NGMP board with a LEON4 processor.

Reviewed-by: Fabien Chouteau <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Sebastian Huber <address@hidden>

v4: Fix coding style.

v5: Fix two typos. Generate an IU instead of FPU exception in case CASA
is not supported by the CPU. Define CASA feature for all SPARC64 CPUs
(due to the #ifndef TARGET_SPARC64 it must go into the #else branch).

This version of the patch passes all of my tests on SPARC32 and SPARC64 so:

Tested-by: Mark Cave-Ayland <address@hidden>

If someone like Richard (added as CC) could give the TCG parts a quick sanity check then given the length of time this patch has been around (and Sebastian's responsiveness) then I'd be okay for this patch to be included in 2.0.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]