Re: [Qemu-devel] [PATCH v3] migration: add more traces

[Juan Quintela]

Alexey Kardashevskiy <address@hidden> wrote:
> On 03/11/2014 04:17 AM, Amit Shah wrote:
>> On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote:
>>> This replaces DPRINTF macro with tracepoints.
>>>
>>> This moves some messages from migration.c to savevm.c.
>>>
>>> This adds tracepoint to signal about fileds failed to migrate.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>> ---
>>>
>>> This is v3. Should I repost the whole thing or just "3/3 v3" is ok? Thanks!
>> 
>> This broke the build on windows:
>> 
>> http://news.gmane.org/find-root.php?message_id=CAFEAcA%5fEa72JTVLJ3Z%2dzUtoe8vg%2bjh8R96mNW2c2x2Mx%5fj%2bFwg%40mail.gmail.com
>> 
>> Please fix.
>
> I am sorry but how? Is it msvc? Is it mingw? Or replace with
> %02x:%02x:%02x:%02x:%02x:%02x?

mingw32.

Replace with %02x:02x or create a

qmeu_ether_ntoa()  function with exactly that code in

utils/cutils.c


Later, Juan.