qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached funct


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function
Date: Tue, 11 Mar 2014 07:11:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/11/2014 06:53 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
> 
> Rebuild the cache_is_cached function.
> 
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Once again, I did NOT give R-b in v1.

> ---
>  page_cache.c | 33 +++++++++++++++------------------
>  1 file changed, 15 insertions(+), 18 deletions(-)
> 

> +    if (it->it_addr == addr) {
> +        /* updata the it_age when the cache hit */

Furthermore, I made a review comment in v1 that you had a typo, but it
went unchanged in this version:

s/updata/update/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]