Re: [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user

[Eric Blake]

On 03/11/2014 06:53 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
> 
> expose the counter that log the times of updating the dirty bitmap to
> end user.
> 
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -651,13 +651,15 @@
>  #
>  # @mbps: throughput in megabits/sec. (since 1.6)
>  #
> +# @dirty-sync-cnt: the times of ram dirty sync (since 1.7)

The earliest this will make it in is 2.0 - and that's if it is treated
as a bug fix.  Otherwise, this needs to be '(since 2.1)'.

'cnt' is an abbreviation; it doesn't hurt to spell things out to say
'dirty-sync-count'.


> @@ -2966,6 +2967,7 @@ Examples:
>            "duplicate":123,
>            "normal":123,
>            "normal-bytes":123456
> +          "dirty-sync-cnt":15

Invalid JSON.  If dirty-sync-cnt is present, "normal-bytes":123456 must
have a comma separating the two elements.

>          }
>       }
>     }
> @@ -2991,6 +2993,7 @@ Examples:
>              "duplicate":123,
>              "normal":123,
>              "normal-bytes":123456
> +            "dirty-sync-cnt":15

And again.  All of your insertions to this example need correction.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature