Re: [Qemu-devel] [PATCH v22 25/25] cleanup QEMUOptionParameter

[Stefan Hajnoczi]

On Mon, Mar 10, 2014 at 03:32:01PM +0800, Chunyan Liu wrote:
> Now all places using QEMUOptionParameter could use QemuOpts too, remove
> QEMUOptionParameter related code.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
>  block.c                   |  69 ++------
>  block/cow.c               |   4 +-
>  block/gluster.c           |   8 +-
>  block/qcow.c              |   4 +-
>  block/qcow2.c             |   6 +-
>  block/qed.c               |   4 +-
>  block/raw-posix.c         |  10 +-
>  block/raw-win32.c         |   2 +-
>  block/raw_bsd.c           |   4 +-
>  block/rbd.c               |   2 +-
>  block/sheepdog.c          |   6 +-
>  block/ssh.c               |   2 +-
>  block/vdi.c               |   2 +-
>  block/vhdx.c              |   4 +-
>  block/vmdk.c              |   6 +-
>  block/vpc.c               |   2 +-
>  block/vvfat.c             |   2 +-
>  include/block/block.h     |   8 +-
>  include/block/block_int.h |  13 +-
>  include/qemu/option.h     |  46 ------
>  qemu-img.c                |  63 +-------
>  util/qemu-option.c        | 401 
> ----------------------------------------------
>  22 files changed, 62 insertions(+), 606 deletions(-)

Please change the commit message to "qemu-option: remove
QEMUOptionParameter".  Commit messages should have a prefix that
indicates which part of the codebase is affected.  And "remove" is more
specific than "cleanup".

Reviewed-by: Stefan Hajnoczi <address@hidden>