Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

[Michael S. Tsirkin]

On Tue, Mar 11, 2014 at 07:53:20PM +0000, Peter Maydell wrote:
> On 11 March 2014 19:46, Dr. David Alan Gilbert <address@hidden> wrote:
> > * Michael S. Tsirkin (address@hidden) wrote:
> >
> >> Shouldn't we prevent the unsupported option from
> >> appearing in qemu output though?
> >> Otherwise how does user know whether it works?
> >
> > I'll make it spit a warning if you try and enable it on a platform
> > that doesn't have a way of doing it; ifdef all the option parsing
> > would just make everywhere messy and in the end we defined it
> > as a debug option.
> 
> When would you want to not enable it? If this is
> purely for debug convenience why not just have "always
> set thread names if the platform allows it" ?
> 
> thanks
> -- PMM

Because we don't want people to start relying on thread naming to
manage the threads outside qemu.
Then we won't be able to change the threading
model. In particular that was the reason we don't
have a monitor command to expose thread IDs for
threads except VCPUs (for which the reasoning is
1 thread per VCPU is the only thing allowed by KVM).

There also can be existing tools that would break if
we changed thread names.

-- 
MST