[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge process |
|
Date: |
Tue, 11 Mar 2014 14:55:18 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/11/2014 02:48 PM, Juan Quintela wrote:
> <address@hidden> wrote:
>> From: ChenLiang <address@hidden>
>>
>> It is inaccuracy and complex that using the transfer speed of
>> migration thread to determine whether the convergence migration.
>> The dirty page may be compressed by XBZRLE or ZERO_PAGE.The counter
>> of updating dirty bitmap will be increasing continuously if the
>> migration can't convergence.
>
> "It is inexact and complex to use the migration transfer speed to
> dectermine weather the convergence of migration."
or even better (plus spelling fixes):
determine whether migration is converging
>
>> @@ -530,21 +523,11 @@ static void migration_bitmap_sync(void)
>> /* more than 1 second = 1000 millisecons */
Pre-existing, but as long as you are touching this area of code:
s/millisecons/milliseconds/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature