[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cac
|
From: |
Benoît Canet |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache() |
|
Date: |
Wed, 12 Mar 2014 10:43:30 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Wednesday 12 Mar 2014 à 10:40:00 (+0100), Kevin Wolf wrote :
> Am 11.03.2014 um 17:41 hat Benoît Canet geschrieben:
> > I have the impression that you are silently fixing other nits;
>
> Am I?
>
> Not intentionally at least. I think I can justify every single line of
> the patch with respect to the bug described in the commit message. We
> need to recursive into the protocol layer, and we need to refresh
> bs->total_sectors. For drivers implementing the callback, we need to
> recurse to bs->file between the internal open/close pair.
>
> I can't see what could be left out in this patch.
I didn't understood the implication on recursion at first sight.
Best regards
Benoît
>
> Kevin
>