Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables

[Gerd Hoffmann]

On Mi, 2014-03-12 at 09:05 -0400, Gabriel L. Somlo wrote:
> On Wed, Mar 12, 2014 at 09:27:18AM +0100, Gerd Hoffmann wrote:
> > I think we should just use e820_table (see pc.c) here.  Loop over it and
> > add a type 19 table for each ram region in there.
> 
> I'm assuming this should be another post-Seabios-compatibility patch,
> at the end of the series, and I should still do the (start,size)
> arithmetic cut'n'pasted from SeaBIOS first, right ?

You should get identical results with both methods.  It's just that the
e820 method is more future proof, i.e. if the numa people add support
for non-contignous memory some day we don't have to adapt the smbios
code to handle it.

cheers,
  Gerd