[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions |
Date: |
Wed, 12 Mar 2014 15:40:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/10/2014 12:04 PM, Tom Musta wrote:
> This patch series addresses concerns raised by Richard Henderson regarding
> redundant
> copies of Advanced Encryption Standard (AES) data and code (see
> http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html).
>
> The patches declare commonly used AES tables in the include/qemu/aes.h header
> file
> and define the tables in util/aes.c, thus eliminating redundant copies.
>
> Minor refactorization of the i386 and ARM instruction models are made to
> utilize
> this common support. The newly added PowerPC instructions are completely
> rewritten and look much more like the i386 equivalents; a substantial amount
> of
> code is eliminated.
>
> Tom Musta (6):
> util: Add S-Box and InvS-Box Arrays to Common AES Utils
> util: Add AES ShiftRows and InvShiftRows Tables
> util: Add InvMixColumns
> target-i386: Use Common ShiftRows and InvShiftRows Tables
> target-arm: Use Common Tables in AES Instructions
> target-ppc: Refactor AES Instructions
Other than the one nit,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/6] Refactor AES Instructions, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 1/6] util: Add S-Box and InvS-Box Arrays to Common AES Utils, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 4/6] target-i386: Use Common ShiftRows and InvShiftRows Tables, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 2/6] util: Add AES ShiftRows and InvShiftRows Tables, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 3/6] util: Add InvMixColumns, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 5/6] target-arm: Use Common Tables in AES Instructions, Tom Musta, 2014/03/10
- [Qemu-devel] [PATCH 6/6] target-ppc: Refactor AES Instructions, Tom Musta, 2014/03/10
- Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions,
Richard Henderson <=