[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.0-rc0 4/6] xics-kvm: Fix reset function
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL for-2.0-rc0 4/6] xics-kvm: Fix reset function |
Date: |
Thu, 13 Mar 2014 03:53:31 +0100 |
From: Alexey Kardashevskiy <address@hidden>
Currently interrupt priorities are set to 0 (highest) at the very
beginning of the guest execution which is not correct and makes the guest
produce random interrupt error messages such as:
"Interrupt 0x1001 (real) is invalid, disabling it".
This also prevents interrupt states from correct migration.
This initializes priority to 0xFF as the emulated XICS does.
Suggested-by: Paul Mackerras <address@hidden>
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hw/intc/xics_kvm.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c
index a5bbc24..c93dae0 100644
--- a/hw/intc/xics_kvm.c
+++ b/hw/intc/xics_kvm.c
@@ -269,7 +269,16 @@ static void ics_kvm_set_irq(void *opaque, int srcno, int
val)
static void ics_kvm_reset(DeviceState *dev)
{
- ics_set_kvm_state(ICS(dev), 1);
+ ICSState *ics = ICS(dev);
+ int i;
+
+ memset(ics->irqs, 0, sizeof(ICSIRQState) * ics->nr_irqs);
+ for (i = 0; i < ics->nr_irqs; i++) {
+ ics->irqs[i].priority = 0xff;
+ ics->irqs[i].saved_priority = 0xff;
+ }
+
+ ics_set_kvm_state(ics, 1);
}
static void ics_kvm_realize(DeviceState *dev, Error **errp)
--
1.8.4.5
- [Qemu-devel] [PULL for-2.0-rc0 0/6] PowerPC patch queue 2014-03-13, Andreas Färber, 2014/03/12
- [Qemu-devel] [PULL for-2.0-rc0 1/6] Revert "KVM: Split QEMUMachine typedef into separate header", Andreas Färber, 2014/03/12
- [Qemu-devel] [PULL for-2.0-rc0 2/6] Move QEMUMachine typedef to qemu/typedefs.h, Andreas Färber, 2014/03/12
- [Qemu-devel] [PULL for-2.0-rc0 4/6] xics-kvm: Fix reset function,
Andreas Färber <=
- [Qemu-devel] [PULL for-2.0-rc0 5/6] spapr-pci: Convert to QOM realize, Andreas Färber, 2014/03/12
- [Qemu-devel] [PULL for-2.0-rc0 6/6] spapr-pci: Convert fprintf() to error_report(), Andreas Färber, 2014/03/12
- [Qemu-devel] [PULL for-2.0-rc0 3/6] pseries: Update SLOF firmware image to qemu-slof-20140304, Andreas Färber, 2014/03/13
- Re: [Qemu-devel] [PULL for-2.0-rc0 0/6] PowerPC patch queue 2014-03-13, Peter Maydell, 2014/03/13