|
| From: | Markus Armbruster |
| Subject: | Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused |
| Date: | Thu, 13 Mar 2014 14:18:56 +0100 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Il 12/03/2014 18:00, Markus Armbruster ha scritto:
>> + } else if (!runstate_check(RUN_STATE_PRELAUNCH)
>> + && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
>
> Why not "if (runstate_is_running())"?
The predicate actually wanted here is "monitor command 'cont' required
to get the guest running", because 'cont' is where the protection is.
My run state test is a crude approximation.
| [Prev in Thread] | Current Thread | [Next in Thread] |