Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest

[Andreas Färber]

Am 13.03.2014 15:17, schrieb Peter Maydell:
> When running under qtest we don't actually have any vcpu threads
> to be starved, so the warning about the I/O thread spinning isn't
> relevant, and the way qtest manipulates the simulated clock means
> the warning is produced a lot as a false positive. Suppress it if
> qtest_enabled(), so 'make check' output is less noisy.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  main-loop.c         |  3 ++-
>  stubs/Makefile.objs |  1 +
>  stubs/qtest.c       | 14 ++++++++++++++
>  3 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 stubs/qtest.c

Looks OK to me, a bit unfortunate that we need a stub, but

Reviewed-by: Andreas Färber <address@hidden>

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg