[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-next] virtio-console: Fix VIRTIO_CONSOLE() c
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [Qemu-devel] [PATCH qom-next] virtio-console: Fix VIRTIO_CONSOLE() cast macro |
|
Date: |
Thu, 13 Mar 2014 16:27:50 +0000 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Thu, Mar 13, 2014 at 05:24:36PM +0100, Andreas Färber wrote:
> Commit 0399a3819b27083ba69b88a9baa9025facab85bd (virtio-console: QOM
> cast cleanup for VirtConsole) broke virtserialport since it shares
> functions and state struct with virtconsole. Let virtconsole inherit
> from virtserialport, and use virtserialport type for casting.
>
> Note that virtio-serial-port is the abstract base type in
> virtio-serial-bus.c, whereas virtserialport is the user-instantiatable
> type in virtio-console.c. Therefore using TYPE_VIRTIO_CONSOLE_SERIAL_PORT.
>
> Reported-by: Richard W.M. Jones <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
This patch fixes the problem for me, thanks.
ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org