Re: [Qemu-devel] [PATCH] virtio-scsi: actually honor sense_size from configuration space

[Fam Zheng]

On Thu, 03/06 11:27, Paolo Bonzini wrote:
> We were always truncating the sense size to 96 bytes.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/scsi/virtio-scsi.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index 6610b3a..b0d7517 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -304,6 +304,8 @@ static void virtio_scsi_command_complete(SCSIRequest *r, 
> uint32_t status,
>                                           size_t resid)
>  {
>      VirtIOSCSIReq *req = r->hba_private;
> +    VirtIOSCSI *s = req->dev;
> +    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
>      uint32_t sense_len;
>  
>      if (r->io_canceled) {
> @@ -317,7 +319,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, 
> uint32_t status,
>      } else {
>          req->resp.cmd->resid = 0;
>          sense_len = scsi_req_get_sense(r, req->resp.cmd->sense,
> -                                       VIRTIO_SCSI_SENSE_SIZE);
> +                                       vs->sense_size);
>          req->resp.cmd->sense_len = tswap32(sense_len);
>      }
>      virtio_scsi_complete_req(req);
> -- 
> 1.8.5.3
> 

With a modified kernel that increased the sense buffer size to 252 in
configuration, this code actually returns 252.

Reviewed-by: Fam Zheng <address@hidden>