Re: [Qemu-devel] [PULL 073/130] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

[Fabien Chouteau]

On 03/14/2014 12:23 PM, Paolo Bonzini wrote:
> Il 07/03/2014 00:33, Alexander Graf ha scritto:
>> +                if (bd.flags | BD_INTERRUPT) {
>> +                    /* Set RXFx */
>> +                    etsec->regs[RSTAT].value |= 1 << (7 - ring_nbr);
>> +
>> +                    /* Set IEVENT */
>> +                    ievent_set(etsec, IEVENT_RXF);
>> +                }
>> +
>> +            } else {
>> +                if (bd.flags | BD_INTERRUPT) {
>> +                    /* Set IEVENT */
>> +                    ievent_set(etsec, IEVENT_RXB);
>> +                }
>> +            }
> 
> Coverity flags this "bd.flags | BD_INTERRUPT" idiom... What did you mean?  
> Can you send a fix to qemu-trivial?
> 

That's a very bad mistake indeed, it's supposed to be a "bd.flags & 
BD_INTERRUPT"...