Re: [Qemu-devel] [PATCH] block: Explicitly specify 'unsigned long long' for VHDX 64-bit constants

[Peter Maydell]

On 14 March 2014 16:35, Laszlo Ersek <address@hidden> wrote:
> On 03/14/14 17:26, Peter Maydell wrote:
>> On 14 March 2014 16:17, Laszlo Ersek <address@hidden> wrote:
>>> "Unsigned long long" is a gnu-ism for C89. It's a standard part of C99.
>>> Last time I checked, qemu used the gnu89 dialect on all build hosts
>>> except SunOS.
>>
>> HACKING says we use C99...
>
> HACKING lies then :)
>
> grep for "std=c99" or "std=gnu99". You will find no hits for the former,
> and one hit for the latter, when the build host is SunOS. (Or just grep
> for '-std='.)
>
> In gcc-4.8.2, -std still defaults to gnu89.

HACKING says what we intend. If we need to pass an argument
to gcc to get it to accept C99 constructs we should fix
configure.

-- PMM