qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix bogus coverity warnings


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/2] dataplane: fix bogus coverity warnings
Date: Fri, 14 Mar 2014 18:25:34 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 14/03/2014 16:14, Stefan Hajnoczi ha scritto:
Coverity detects when variable are accessed under a mutex most of the time.  It
warns when they are not accessed under the mutex.  I initialized variables
before the mutex and threads that access them even exist - Coverity doesn't
like that.  Fix the code.

Stefan Hajnoczi (2):
  iothread: fix bogus coverity warning
  rfifolock: fix bogus coverity warning

 iothread.c       | 5 ++++-
 util/rfifolock.c | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)


Nah, I think Coverity is wrong. It should detect initialization of the mutex, and treat surrounding code as single-threaded. I silenced the defects in the report, like others before.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]