[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Makefile: Fix "make clean"
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] Makefile: Fix "make clean" |
|
Date: |
Mon, 17 Mar 2014 11:56:48 +0000 |
On 17 March 2014 06:15, Stefan Weil <address@hidden> wrote:
> Am 17.03.2014 02:35, schrieb Fam Zheng:
>> This fixes a dangerous bug: "make clean" after "make distclean" will
>> delete every single file including those under .git, if you do in-tree
>> build!
>>
>> Rationale: A first "make distclean" will unset $(DSOSUF), a following
>> "make distclean" or "make clean" will find all the files and delete it.
>>
>> Fix it by explicitly typing the file extensions here, and combine
>> multiple find invocations into one.
>>
>> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Stefan Weil <address@hidden>
>
> Hello Peter,
>
> this is a bugfix which fixes a potential danger for a developer's
> working directory, so I think it should be fixed directly (not via
> qemu-trivial).
Agreed; applied to master, thanks.
-- PMM