|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible |
Date: | Mon, 17 Mar 2014 13:32:04 +0100 |
> >> C 07 Communication controller > >> 00 Serial controller > >> 00 8250 > >> 01 16450 > >> 02 16550 > >> What about multi_serial_pci_init() -- should it too set prog-if > >> like this? > > > > I'm not completely sure what the correct value should be for > > multi_serial_pci_init so I've left that alone. There's also 07 02 00 that > > means multiport serial controller that might apply for that case. For the > > simple case I've sent the patch for I had a client expecting this value so > > I > > think it is correct for that at least but I don't know about the multiport > > case. > > Also Gerd Hoffmann said he has picked this patch up so I'm adding him to > cc too. The multiport variants are simply multiple 16550 chips mapped one after the other. So "02" is better than "00". I don't know what exactly the multiport serial controller is supposed to be. cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |