Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling

[Paolo Bonzini]

Il 17/03/2014 13:33, Markus Armbruster ha scritto:
> This patch changes:
>
>     from        to          introduced in
>     acpi        acpitable   0c764a9 v1.5.0
>     boot-opts   boot        3d3b830 v1.0
>     smp-opts    smp         12b7f57 v1.6.0
>
> All three have calcified into ABI already.

What has calcified into ABI is only what has likely been used as ABI. 
The other is an ABI that won't be nice to break, but it is not calcified 
yet.

There are two aspects of this:

1) QMP queries.  Did any of the above conversions introduce new 
sub-options?  Or was any suboption introduced after that point?  If not, 
there's hardly a reason for anyone to query for acpi/boot-opts/smp-opts 
QemuOpts

2) readconfig.  I think readconfig is not practically usable until at 
least memory will be part of it.  For this reason, -readconfig is not a 
worry; not yet at least: it will be in 2.1 once -m is converted.

> > > I'm for including this patch in 2.0.
> Not without explaining the ABI breakage in the commit message.  We
> should also make sure to cover it in the release notes[*].

I agree.

> Moreover, if exceptions from the rule "QemuOptsList name must match the
> name of the (non-sugared) command line option using it" are or will be
> permissible, then Amos's comment on QemuOptsList member name needs to be
> clarified.

I like your idea of -memory as a synonym for -m.

Paolo