[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids |
|
Date: |
Tue, 18 Mar 2014 19:07:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/18/14 15:48, Michael S. Tsirkin wrote:
> when using signature for table ID, we forgot to byte-swap it.
> signatures are really ASCII strings, let's treat them as such.
> While at it, get rid of most of _SIGNATURE macros.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/i386/acpi-defs.h | 14 --------------
> hw/i386/acpi-build.c | 31 ++++++++++++++++---------------
> 2 files changed, 16 insertions(+), 29 deletions(-)
Looks reasonable. Of course you'll probably want Marcel's R-b.
Reviewed-by: Laszlo Ersek <address@hidden>