[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power o
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2. |
|
Date: |
Wed, 19 Mar 2014 08:17:52 +0530 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 05, 2014 at 06:59:29AM -0700, Eric Blake wrote:
> On 03/05/2014 01:32 AM, Bharata B Rao wrote:
> > PowerPC kernel expects the number of SMT threads in a core to be a power
> > of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel
> > crash if invalid threads count is specified.
> >
> > Prevent this crash and make it a graceful exit from QEMU itself by
> > validating the user supplied threads count.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
> > ---
> > Changes in v2: Use is_power_of_2() from QEMU itself instead of depending
> > on libm.
> > v1: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00660.html
> > v0: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00355.html
>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Stewart Smith <address@hidden>
Alexander/Andreas,
Could you take this patch into your tree ?
Regards,
Bharata.