[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RESEND v4 5/5] virtio-rng: avoid default_backend ref
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH RESEND v4 5/5] virtio-rng: avoid default_backend refcount leak |
Date: |
Wed, 19 Mar 2014 08:58:57 +0100 |
QOM child properties take a reference to the object and release it when
the property is deleted. Therefore we should unref the default_backend
after we have added it as a child property.
Cc: KONRAD Frederic <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/virtio/virtio-rng.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index cbf0138..b6ab361 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -162,6 +162,9 @@ static void virtio_rng_device_realize(DeviceState *dev,
Error **errp)
OBJECT(vrng->conf.default_backend),
NULL);
+ /* The child property took a reference, we can safely drop ours now */
+ object_unref(OBJECT(vrng->conf.default_backend));
+
object_property_set_link(OBJECT(dev),
OBJECT(vrng->conf.default_backend),
"rng", NULL);
--
1.8.5.3
- [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes, Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 1/5] qom: split object_property_set_link(), Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 3/5] qom: make QOM link property unref optional, Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link(), Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 5/5] virtio-rng: avoid default_backend refcount leak,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH RESEND v4 2/5] qom: don't make link NULL on object_property_set_link() failure, Stefan Hajnoczi, 2014/03/19
- Re: [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes, Paolo Bonzini, 2014/03/19