Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids

[Marcel Apfelbaum]

On Tue, 2014-03-18 at 19:07 +0100, Laszlo Ersek wrote:
> On 03/18/14 15:48, Michael S. Tsirkin wrote:
> > when using signature for table ID, we forgot to byte-swap it.
> > signatures are really ASCII strings, let's treat them as such.
> > While at it, get rid of most of _SIGNATURE macros.
> > 
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> >  hw/i386/acpi-defs.h  | 14 --------------
> >  hw/i386/acpi-build.c | 31 ++++++++++++++++---------------
> >  2 files changed, 16 insertions(+), 29 deletions(-)
> 
> Looks reasonable. Of course you'll probably want Marcel's R-b.
I agree with the changes, but sadly it does not resolve the problem for ppc64 
hosts.

Reviewed-by: Marcel Apfelbaum <address@hidden>

> 
> Reviewed-by: Laszlo Ersek <address@hidden>