Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()

[Eduardo Habkost]

On Wed, Mar 19, 2014 at 04:53:41PM +0800, Chen Fan wrote:
> introduce x86_cpu_topo_ids_from_index() to calculate the cpu topology
> information, and the compat old mode mechanism moved into there.
> remove unused funciton x86_apicid_from_cpu_idx().
> 
> Signed-off-by: Chen Fan <address@hidden>
[...]
> -static inline apic_id_t x86_apicid_from_cpu_idx(unsigned nr_cores,
> -                                                unsigned nr_threads,
> -                                                unsigned cpu_index)
> +static inline void x86_topo_ids_from_apic_id(unsigned nr_cores,
> +                                             unsigned nr_threads,
> +                                             apic_id_t apic_id,
> +                                             X86CPUTopoInfo *topo)

You need to squash this patch and patch 3/4 together, otherwise we get
unit test failures in the intermediate tree.

Otherwise, patch looks good.

-- 
Eduardo