[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.0 7/7] virtio-rng: Avoid default_backend refcou
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL for-2.0 7/7] virtio-rng: Avoid default_backend refcount leak |
Date: |
Wed, 19 Mar 2014 22:45:42 +0100 |
From: Stefan Hajnoczi <address@hidden>
QOM child properties take a reference to the object and release it when
the property is deleted. Therefore we should unref the default_backend
after we have added it as a child property.
Cc: KONRAD Frederic <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hw/virtio/virtio-rng.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index cbf0138..b6ab361 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -162,6 +162,9 @@ static void virtio_rng_device_realize(DeviceState *dev,
Error **errp)
OBJECT(vrng->conf.default_backend),
NULL);
+ /* The child property took a reference, we can safely drop ours now */
+ object_unref(OBJECT(vrng->conf.default_backend));
+
object_property_set_link(OBJECT(dev),
OBJECT(vrng->conf.default_backend),
"rng", NULL);
--
1.8.4.5
- [Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 2/7] vl.c: Fix OpenBSD compilation issue due to namespace collisions, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 1/7] vl.c: Fix memory leak in qemu_register_machine(), Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 7/7] virtio-rng: Avoid default_backend refcount leak,
Andreas Färber <=
- [Qemu-devel] [PULL for-2.0 3/7] qom: Split object_property_set_link(), Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 4/7] qom: Don't make link NULL on object_property_set_link() failure, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 6/7] qom: Add check() argument to object_property_add_link(), Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 5/7] qom: Make QOM link property unref optional, Andreas Färber, 2014/03/19
- Re: [Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19, Peter Maydell, 2014/03/19