[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1 |
|
Date: |
Wed, 19 Mar 2014 23:47:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 17.03.2014 22:55, schrieb Artyom Tarasenko:
> Hi Andreas,
>
> On Mon, Mar 17, 2014 at 8:59 PM, Andreas Färber <address@hidden> wrote:
>>> this patch seems still be missing in master. Is it causing any problems?
>>
>> It does not apply without the preceding patches. Here's my cherry-pick
>> result:
>> [...]
>> I.e. we might change 1 -> 4 in the SysBus API, but would that work given
>> that endianness is being changed alongside?
>
> Yes, and that's the point of this patch. PCI configuration space is
> little-endian. With 1 byte access size, no byte swapping happens, so
> the bug is hidden.
> But on 32- and 16- bit accesses the bytes are swapped.
I think you misunderstood my question: I wanted to know whether
switching from SysBus API to pure MemoryRegion API was part of the fix
or an independent cleanup. But now that I'm going through the respun
series it doesn't really matter any more...
Andreas