Re: [Qemu-devel] [PATCH v5 0/3] spapr: fix H_SET_MODE

[Andreas Färber]

Am 20.03.2014 01:03, schrieb Alexey Kardashevskiy:
> This fixes H_SET_MODE.
> Changes:
> v5:
> * fixed code style
> 
> v4:
> * rebased on top of current ppc-next.
> * changed PPC2_ISA207S flag value
> 
> 
> Alexey Kardashevskiy (3):
>   target-ppc: introduce powerisa-207-server flag
>   spapr_hcall: fix little-endian resource handling in H_SET_MODE

Thanks, applied these two to my ppc-next:
https://github.com/afaerber/qemu-cpu/commits/ppc-next

>   spapr_hcall: add address-translation-mode-on-interrupt resource in
>     H_SET_MODE

This doesn't strike me as a bug fix worthy of -rc1? Does anything
severely break without it that would justify putting it in -rc2?

Also some additional reviewer would assure me there's been no oversight.

Regards,
Andreas

>  hw/ppc/spapr_hcall.c        | 67 
> +++++++++++++++++++++++++++++++++++++++------
>  include/hw/ppc/spapr.h      |  9 ++++--
>  target-ppc/cpu.h            |  4 +++
>  target-ppc/translate_init.c |  3 +-
>  4 files changed, 72 insertions(+), 11 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg