Re: [Qemu-devel] [PATCH v22 08/25] cow.c: replace QEMUOptionParameter with QemuOpts

[Chunyan Liu]

2014-03-11 23:28 GMT+08:00 Eric Blake <address@hidden>:

On 03/10/2014 01:31 AM, Chunyan Liu wrote:
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
>  block/cow.c | 54 ++++++++++++++++++++++++++----------------------------
>  1 file changed, 26 insertions(+), 28 deletions(-)
>

> @@ -414,14 +412,14 @@ static BlockDriver bdrv_cow = {
>      .bdrv_probe     = cow_probe,
>      .bdrv_open      = cow_open,
>      .bdrv_close     = cow_close,
> -    .bdrv_create    = cow_create,
> +    .bdrv_create2   = cow_create,
>      .bdrv_has_zero_init     = bdrv_has_zero_init_1,
>
>      .bdrv_read              = cow_co_read,
>      .bdrv_write             = cow_co_write,
>      .bdrv_co_get_block_status   = cow_co_get_block_status,
>
> -    .create_options = cow_create_options,
> +    .create_opts       = &cow_create_opts,

Inconsistent alignment of =, and inconsistent use of & (it is not needed
here, '.create_opts = cow_create_opts' is just fine).

& is needed, since cow_create_opts is a struct, but .create_opts is struct *;

It's different from cow_create_options, which is a struct array, .create_options

is struct *, so it can simply let the pointer = array name.

 

But those are both minor;

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org