[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode |
Date: |
Thu, 20 Mar 2014 08:58:11 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 12, 2014 at 08:27:18AM +0100, Jan Kiszka wrote:
> On 2014-02-11 14:08, Samuel Thibault wrote:
> > Hello,
> >
> > This is a respin of IPv6 in Qemu -net user mode.
> >
> > These patches add ICMPv6, NDP, and make UDP and TCP compatible with
> > IPv6. We have made some refactoring to make current code compatible with
> > IPv6.
> >
> > Some patches, like 2 and 13, can be reviewed using
> > "interdiff -w /dev/null patchfile"
> > to get rid of the indentation.
>
> The alternative is to split reindention from refactoring patches.
>
> >
> > Difference with version 2 is:
> > - The default IP range has been made fec0::/64 instead of fc00::/64
> >
>
> This is very valuable work. Unfortunately, I'm lacking time to review or
> even test this ATM. If someone else could, that would be great.
I also feel a little sad to see this major feature languish but don't
have much time at the moment.
My suggestion is to split all the preparation and cleanups into a
smaller patch series that can be applied easily.
It will make the real IPv6 series smaller and hopefully more amenable to
review.
Stefan