qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock
Date: Thu, 20 Mar 2014 08:18:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

"Dr. David Alan Gilbert (git)" <address@hidden> writes:

> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Markus Armbruster spotted that the XBZRLE.lock might get initalised
> multiple times in the case of a second attempted migration, and
> that's undefined behaviour for pthread_mutex_init.
>
> This patchset is based on Markus' proto-patch in the discussions
> off v1.
>
> --
> v2
>    Rework completely based on Markus's patch
>
> Dr. David Alan Gilbert (2):
>   Provide init function for ram migration
>   Init the XBZRLE.lock in ram_mig_init

Second patch does a fair but more than its subject suggests.  Perhaps
"XBZRLE: Rework locking to fix double initialization" would be better.
Still doesn't cover the upgrade from debugging prints to proper error
reporting.  Maybe that should be a separate patch.  Up to you.

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]