|
From: | BALATON Zoltan |
Subject: | Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible |
Date: | Thu, 20 Mar 2014 17:58:46 +0100 (CET) |
User-agent: | Alpine 2.02 (LMD 1266 2009-07-14) |
On Thu, 20 Mar 2014, Paolo Bonzini wrote:
Il 20/03/2014 17:01, BALATON Zoltan ha scritto:On Thu, 20 Mar 2014, Paolo Bonzini wrote:Il 20/03/2014 16:42, Michael Tokarev ha scritto:10.03.2014 22:40, BALATON Zoltan wrote:Ping! http://patchwork.ozlabs.org/patch/324674/Thanks, applied to -trivial.No, please don't; this needs to be done for new machine types only.Why? I tried running a Windows XP image that was set up before this patch and it did not complain about changed hardware. Or is there another reason I'm missing?Classes (or anything guest-visible in fact) must never ever be changed for the same machine type. It's a rule.
The class did not change only the prog interface field after it (which is guest visible but I think most guests just ignore it). So then what's the correct way to do it? Do I need to change the patch or can it be merged as it is the next time a new machine type is added?
Regards, BALATON Zoltan
[Prev in Thread] | Current Thread | [Next in Thread] |