[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE |
Date: |
Thu, 20 Mar 2014 13:53:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/18/2014 06:24 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
>
> update the doc of XBZRLE
Having the subject line and the body of the commit message be identical
is redundant. And just by looking at the commit message, I can't see
WHY you are updating things. If you were to keep this as a separate
commit, I'd suggest it look more like:
XBZRLE: document cache miss policy
Add a section to the XBZRLE documentation describing how the page cache
determines which pages are hot.
That said, I think you should squash this documentation update into
patch 5/10 where you actually implement it, so that a single patch
becomes self-documenting why you went with this design. At which point,
the combined patch commit message should look something like:
XBZRLE: optimize XBZRLE to decrease cache misses
...existing text from 5/10...
Additionally, document the new cache age policy.
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> docs/xbzrle.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt
> index cc3a26a..cdf1e3e 100644
> --- a/docs/xbzrle.txt
> +++ b/docs/xbzrle.txt
> @@ -71,6 +71,13 @@ encoded buffer:
> encoded length 24
> e9 07 0f 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 03 01 67 01 01 69
>
> +The strategy of updating cache
> +=================================
Copy-and-paste from bad examples already in this file, but it's nicer
when the length of ==== matches the heading it is paired with.
> +Keeping the hot page in cache is effective to decrease cache missing.
> +XBZRLE use a counter as the age of page. The counter will increase
> +after the ram dirty bitmap syncing. When cache conflicts XBZRLE only
> +replace the old page in cache.
Suggestions for better grammar:
Cache update strategy
=====================
Keeping the hot pages in the cache is effective for decreased cache
misses. XBZRLE uses a counter as the age of each page. The counter will
increase after each ram dirty bitmap sync. When a cache conflict is
detected, XBZRLE will only evict pages in the cache that are older than
a threshold.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 01/10] XBZRLE: Fix one XBZRLE corruption issues, (continued)
- [Qemu-devel] [PATCH v3 01/10] XBZRLE: Fix one XBZRLE corruption issues, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 04/10] migration: expose xbzrle cache miss rate, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 02/10] migration: Add counters of updating the dirty bitmap, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 08/10] migration: optimize xbzrle by reducing data copy, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 07/10] migration: Fix the migrate auto converge process, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 05/10] XBZRLE: optimize XBZRLE to decrease the cache missing, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE, arei.gonglei, 2014/03/18
- Re: [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE,
Eric Blake <=
- [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 09/10] migration: clear the dead code, arei.gonglei, 2014/03/18
- Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues, Eric Blake, 2014/03/20