qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and f


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues
Date: Thu, 20 Mar 2014 13:56:33 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/18/2014 06:24 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
> 
> V2-->V3
> * rename the bitmap_sync_cnt to bitmap_sync_counter
> * expose xbzrle cache miss rate
> 
> V1-->V2
> * expose the counter that logs the times of updating the dirty bitmap to end 
> user.
> 
> a. Optimization the xbzrle remarkable decrease the cache misses.
>     The efficiency of compress increases more than fifty times.
>     Before the patch set, the cache almost totally miss when the 
>     number of cache item less than the dirty page number. Now the
>     hot pages in the cache will not be replaced by other pages. 
> 
> b. Reducing the data copy
> 
> c. Fix two corruption issues.

Your QAPI changes were marked 2.1, but this series also includes a
corruption fix.  Please split this series into patches that MUST be
applied for 2.0 as bug fixes, vs. the patches that are a feature
enhancement (or else with strong justification why a speed optimization
is safe enough to be considered a bug fix, if you think the whole series
belongs in 2.0).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]