|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines |
| Date: | Thu, 20 Mar 2014 22:57:13 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 20/03/2014 21:16, Michael S. Tsirkin ha scritto:
Seems too aggressive: can't we detect the broken iasl? E.g. won't it fail to disassemble expected AML files?
Yes.
Also, won't this broken iasl generate corrupt AML on output? If yes we should detect this at configure time instead?
No, the output is fine. There are patches from Debian (that I updated and applied to Fedora last year) that take care of fixing endianness on output, but no such patches for the disassembly.
On one hand, I'm fine with not running IASL at all on big-endian machines. On the other hand, it will certainly cause the patches to bitrot.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |