qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines
Date: Thu, 20 Mar 2014 23:03:04 +0000

On 20 March 2014 22:41, Marcel Apfelbaum <address@hidden> wrote:
> On Thu, 2014-03-20 at 22:17 +0000, Peter Maydell wrote:
>> echo "trivial iasl source" | iasl --compile-options | iasl
>> --disassemble-options | grep "error"
>>
>> Fill in the handwaving with actual syntax ;-)

> Problem with this solution is that if we start from the source,
> it will compile into a *wrong* AML (e.g header length will be BE and not LE),
> then the disassemble will *succeed* (!!!).
> However, the expected AML file will be in the right format and fail :(.

Well, grep for 'some integer that comes out wrong due
to the iasl bug', if it doesn't always result in an error
like the case you reported to the iasl mailing list.

You need to write this code at some point because we do
need to be able to configure-time detect whether we have
a working iasl or a broken one, once fixed ones get out
into the wild. It doesn't seem like it ought to be that hard
to just do it right to start with...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]