|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow |
Date: | Fri, 21 Mar 2014 08:23:45 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/21/2014 12:07 AM, Mark Cave-Ayland wrote: > > This basic patch looks good to me. My only comment is that I suspect for > bisection purposes it may be better to split this into 2 patches - one to > perform the conversion of all existing constants to INT*_MAX and INT*_MIN, and > then a second to add your change to prevent the crash. I'll let Richard have > the final say though. I think one patch is fine. r~
[Prev in Thread] | Current Thread | [Next in Thread] |