[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32
From: |
Stuart Brady |
Subject: |
Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32 |
Date: |
Fri, 21 Mar 2014 23:39:48 +0000 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Fri, Mar 21, 2014 at 11:35:12PM +0000, Stuart Brady wrote:
> On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote:
> > diff --git a/tcg/README b/tcg/README
> > index f178212..160cbe8 100644
> > --- a/tcg/README
> > +++ b/tcg/README
> > @@ -306,6 +306,11 @@ This operation would be equivalent to
> >
> > dest = (t1 & ~0x0f00) | ((t2 << 8) & 0x0f00)
> >
> > +* trunc_i32 t0, t1, pos
> > +
> > +For 64-bit hosts only, right shift the 64-bit input T1 by POS and
> > +truncate to 32-bit output T0. Depending on the host, this may be
> > +a simple mov/shift, or may require additional canonicalization.
>
> Surely trunc_rshift_i64_i32, which is used elsewhere in this patch?
... but not used consistently, so this affects more than just the README.
Forgot to mention that! :-)
> ... or trunc_shr_i64_i32 as we use 'shr' for the existing shift-right op.
Cheers,
Stuart
- [Qemu-devel] [PATCH 00/14] tcg/sparc v8plus code generation, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 01/14] tcg: Fix missed pointer size != TCG_TARGET_REG_BITS changes, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 03/14] tcg-sparc: Remove most uses of TCG_TARGET_REG_BITS, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 04/14] tcg-sparc: Support trunc_i32, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 05/14] tcg-sparc: Use 64-bit registers with sparcv8plus, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 06/14] tcg-sparc: Use the RETURN instruction, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 07/14] tcg-sparc: Implement muls2_i32, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 08/14] tcg-sparc: Tidy check_fit_* tests, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 09/14] tcg-sparc: Don't handle mov/movi in tcg_out_op, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 10/14] tcg-sparc: Hoist common argument loads in tcg_out_op, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 11/14] tcg-sparc: Fixup function argument types, Richard Henderson, 2014/03/17
- [Qemu-devel] [PATCH 12/14] tcg-sparc: Fix small 32-bit movi, Richard Henderson, 2014/03/17