[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/9] vnc: Remove default_mon usage
From: |
Cole Robinson |
Subject: |
[Qemu-devel] [PATCH v2 2/9] vnc: Remove default_mon usage |
Date: |
Fri, 21 Mar 2014 19:42:21 -0400 |
These errors don't seem user initiated, so forcibly printing to the
monitor doesn't seem right. Just use error_report.
Cc: Anthony Liguori <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
---
v2:
Use error_report instead of fprintf
ui/vnc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 5925774..2d7def9 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -996,7 +996,7 @@ static void audio_add(VncState *vs)
struct audio_capture_ops ops;
if (vs->audio_cap) {
- monitor_printf(default_mon, "audio already running\n");
+ error_report("audio already running");
return;
}
@@ -1006,7 +1006,7 @@ static void audio_add(VncState *vs)
vs->audio_cap = AUD_add_capture(&vs->as, &ops, vs);
if (!vs->audio_cap) {
- monitor_printf(default_mon, "Failed to add audio capture\n");
+ error_report("Failed to add audio capture");
}
}
--
1.8.5.3
- [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 1/9] slirp: Remove default_mon usage, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 3/9] error: Privatize error_print_loc, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 4/9] monitor: Remove unused monitor_print_filename, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 6/9] qerror.h: Remove unused error classes, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if using qmp, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 7/9] qerror.h: Remove QERR defines that are only used once, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 8/9] qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 9/9] error: Remove some unused headers, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 2/9] vnc: Remove default_mon usage,
Cole Robinson <=
- Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Paolo Bonzini, 2014/03/22
- Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Luiz Capitulino, 2014/03/27