Re: [Qemu-devel] [RFC PATCH 07/12] timer: add cpu_icount_to_ns function.

[Paolo Bonzini]

Il 21/03/2014 20:17, address@hidden ha scritto:
> From: KONRAD Frederic <address@hidden>
>
> This adds cpu_icount_to_ns function which is needed for reverse execution.
>
> It returns the time for a specific instruction.
>
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
>  cpus.c               | 9 +++++++--
>  include/qemu/timer.h | 1 +
>  2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 825d438..007de34 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -146,9 +146,9 @@ static int64_t cpu_get_icount_locked(int with_bias)
>      }
>
>      if (with_bias) {
> -        return timers_state.qemu_icount_bias + (icount << icount_time_shift);
> +        return timers_state.qemu_icount_bias + cpu_icount_to_ns(icount);
>      } else {
> -        return icount << icount_time_shift;
> +        return cpu_icount_to_ns(icount);
>      }
>  }
>
> @@ -178,6 +178,11 @@ int64_t cpu_get_icount_wo_bias(void)
>      return icount;
>  }
>
> +int64_t cpu_icount_to_ns(int64_t icount)
> +{
> +    return icount << icount_time_shift;
> +}
> +
>  /* return the host CPU cycle counter and handle stop/restart */
>  /* Caller must hold the BQL */
>  int64_t cpu_get_ticks(void)
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index da47194..0861d99 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -753,6 +753,7 @@ static inline int64_t get_clock(void)
>  int64_t cpu_get_icount_wo_bias(void);
>  int64_t cpu_get_icount(void);
>  int64_t cpu_get_clock(void);
> +int64_t cpu_icount_to_ns(int64_t icount);
>
>  /*******************************************/
>  /* host CPU ticks (if available) */

Reviewed-by: Paolo Bonzini <address@hidden>