[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage |
|
Date: |
Sat, 22 Mar 2014 21:14:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 12.03.2014 08:35, schrieb Gerd Hoffmann:
> On Di, 2014-03-11 at 19:15 -0400, Cole Robinson wrote:
>> These errors don't seem user initiated, so forcibly printing to the
>> monitor doesn't seem right. Just print to stderr.
>>
>> Cc: Anthony Liguori <address@hidden>
>> Cc: Gerd Hoffmann <address@hidden>
>> Signed-off-by: Cole Robinson <address@hidden>
>
> Reviewed-by: Gerd Hoffmann <address@hidden>
Both should use error_report(), no? We really need clear-to-understand
rules of when to use which API and then stick with them.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage, (continued)
[Qemu-devel] [PATCH 3/6] error: Privatize error_print_loc, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 6/6] error: Print error_report() to stderr if using qmp, Cole Robinson, 2014/03/11