[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filena
|
From: |
Cole Robinson |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename |
|
Date: |
Sat, 22 Mar 2014 17:44:07 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/22/2014 04:06 PM, Andreas Färber wrote:
> Am 12.03.2014 00:15, schrieb Cole Robinson:
>> Cc: Luiz Capitulino <address@hidden>
>> Cc: Markus Armbruster <address@hidden>
>> Signed-off-by: Cole Robinson <address@hidden>
>
> Given that it even had its own stub file, the commit message should
> please explain why it is no longer needed and thus okay to drop.
>
> Regards,
> Andreas
>
The last usage of it was dropped with:
commit fbe2e26c15af35e4d157874dc80f6a19eebaa83b
Author: Kevin Wolf <address@hidden>
Date: Wed Jun 19 16:10:55 2013 +0200
hmp: Make "info block" output more readable
Previously it was used to escape file= and backing_file= in 'info block' output.
I sent this patch because I noticed it was unused, maybe someone else can
comment on whether it's still useful?
- Cole
- Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage, (continued)
Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage, Markus Armbruster, 2014/03/12
[Qemu-devel] [PATCH 3/6] error: Privatize error_print_loc, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 6/6] error: Print error_report() to stderr if using qmp, Cole Robinson, 2014/03/11