[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filena
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename |
Date: |
Mon, 24 Mar 2014 14:46:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 24.03.2014 14:09, schrieb Luiz Capitulino:
> On Sat, 22 Mar 2014 21:06:41 +0100
> Andreas Färber <address@hidden> wrote:
>
>> Am 12.03.2014 00:15, schrieb Cole Robinson:
>>> Cc: Luiz Capitulino <address@hidden>
>>> Cc: Markus Armbruster <address@hidden>
>>> Signed-off-by: Cole Robinson <address@hidden>
>>
>> Given that it even had its own stub file, the commit message should
>> please explain why it is no longer needed and thus okay to drop.
>
> Because it's unused?
That's no real answer. Why did it need to be escaped before the commit
Cole pointed to and now no longer is?
My point was that someone went throught the hassle of creating a stub
file just for this functionality, so it's not some random unused
function in some file. (But I'm not particularly attached to it, just
cautioning about removing too much in this non-verbose way, making it
hard to follow for outsiders.)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage, (continued)
[Qemu-devel] [PATCH 3/6] error: Privatize error_print_loc, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp, Cole Robinson, 2014/03/11
[Qemu-devel] [PATCH 6/6] error: Print error_report() to stderr if using qmp, Cole Robinson, 2014/03/11