Re: [Qemu-devel] [PATCH] target-arm: add support for v8 SHA1 and SHA256 instructions

[Peter Maydell]

On 25 March 2014 17:18, Peter Maydell <address@hidden> wrote:
> On 25 March 2014 16:46, Andreas Färber <address@hidden> wrote:
>> Am 25.03.2014 17:27, schrieb Ard Biesheuvel:
>>> @@ -630,6 +630,8 @@ enum arm_features {
>>>      ARM_FEATURE_V8_AES, /* implements AES part of v8 Crypto Extensions */
>>>      ARM_FEATURE_CBAR, /* has cp15 CBAR */
>>>      ARM_FEATURE_CRC, /* ARMv8 CRC instructions */
>>> +    ARM_FEATURE_V8_SHA1, /* implements SHA1 part of v8 Crypto Extensions */
>>> +    ARM_FEATURE_V8_SHA256, /* implements SHA256 part of v8 Crypto 
>>> Extensions */
>>>  };
>>
>> Do these really need to be separate features? We only have 32 feature
>> bits.
>
> No, we have 64. We overflowed 32 bits a little while back :-)

Incidentally there's no limit at 64 either -- we can always define
an arm_extended_feature() for feature bits 64 and up if we get
that far.

-- PMM