[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 04/12] icount: introduce icount timer.
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 04/12] icount: introduce icount timer. |
Date: |
Tue, 25 Mar 2014 20:22:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
fred konrad writes:
> From: KONRAD Frederic <address@hidden>
> This introduces a new timer based only on instruction counter and without any
> compensation.
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
> cpus.c | 19 ++++++++++++-------
> include/qemu/timer.h | 9 ++++++++-
> qemu-timer.c | 8 +++++++-
> stubs/cpu-get-icount.c | 2 +-
> 4 files changed, 28 insertions(+), 10 deletions(-)
> diff --git a/cpus.c b/cpus.c
> index 89f4b26..e646bac 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -132,7 +132,7 @@ typedef struct TimersState {
> static TimersState timers_state;
> /* Return the virtual CPU time, based on the instruction counter. */
> -static int64_t cpu_get_icount_locked(void)
> +static int64_t cpu_get_icount_locked(int with_bias)
[...]
Nitpick; these should be declared as bool.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- [Qemu-devel] [RFC PATCH v2 00/12] Reverse execution., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 01/12] icount: put icount variables into TimerState., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 05/12] icount: check for icount clock deadline when cpu loop exits., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 03/12] migration: make qemu_savevm_state public., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 07/12] timer: add cpu_icount_to_ns function., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 11/12] cexe: synchronize icount on the next event., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 08/12] introduce reverse execution mechanism., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 04/12] icount: introduce icount timer., fred . konrad, 2014/03/25
- Re: [Qemu-devel] [RFC PATCH v2 04/12] icount: introduce icount timer.,
Lluís Vilanova <=
- [Qemu-devel] [RFC PATCH v2 02/12] migration: migrate icount fields., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 10/12] cpu-exec: trigger a debug request when rexec stops., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 09/12] gdbstub: allow reverse execution in gdb stub., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 06/12] icount: make icount extra computed on icount clock as well., fred . konrad, 2014/03/25
- [Qemu-devel] [RFC PATCH v2 12/12] cexe: allow to enable reverse execution., fred . konrad, 2014/03/25