qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS
Date: Tue, 25 Mar 2014 22:20:04 +0000

On 25 March 2014 21:47, James Hogan <address@hidden> wrote:
> Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a
> new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of
> sync ever since.
>
> Bump it up to 14 so that it matches the number of NEW_AUX_ENT's that
> need to be counted in create_elf_tables().

This code could clearly use at least an assert that we've not written more
entries than we should, or ideally restructuring somehow so that we don't
have to set DLINFO_ITEMS by hand in the first place...

Reviewed-by: Peter Maydell <address@hidden>
for the immediate fix, though.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]